-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with api_only applications #87
Conversation
This looks great!
I think this is ok, since this requires Rails 7+. I wouldn't worry too much about that. |
Thanks for the PR! It works fine for me so far but I've encountered one issue and I'm not quite sure if it's due to my setup or the PR here: I can't unpause a queue anymore. I'm a bloody beginner when it comes to Rails and especially Turbo still, so I'm unsure if the issue is due to my setup, the fact that I converted my Rails app to an API only app recently or something related to the PR here, so take it with a grain of salt: After pausing a queue (which works fine) it does update to button to show
If I manually send a
Lemme know if I can help and sorry in case it's not related to the PR here! |
Branch rebased and fixed CSS importing, if anyone wants to try it:
|
I'm testing this for one of our apps that does not have any UI. so far no issues! |
@InteNs can you tell me a bit more about your application? Rails version? Are you using API-only mode? Do you have propshaft or sprockets in your gemfile? |
Any update on this @rosa ? |
Sorry, I hadn't realised this was ready. I thought there was still an issue, but I see it was not related to Mission Control in the end. I'll try to review next week! |
@zavan any chance you can merge main into this? I need the updated recurring tasks support ;) |
@zavan thanks a lot! I was just testing this locally, and I can't reproduce that issue. Things look good to me here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work here @zavan, thanks a lot! 🙇♀️
Hi, just wanted to see if this is going to be pushed out as a version change soon. Thanks! |
@sebglazebrook, is it working ok for you? I think there were still a few open issues that I haven't had the time to look at 😳 And realistically, I won't have time until at least a month from now. The open issues are here, one is about CSS and the other one is the Queue Pause button being broken. |
This broke one of my apps which is using sprockets on Rails 7.1.4. (specifically, it broke the assets in that app) |
Broke two of my Rails 7.2 apps that are still on sprockets. Agree, seems strange to introduce a breaking change without more fanfare. |
FWIW, breaking changes are expected with little ceremony while in these very early versions. In any case, I didn't judge correctly how much breakage this was going to cause, so I'm going to revert this on version 0.3.3 and will revisit after that. Sorry about the trouble! |
This is an attempt to address #60 and make this gem work with API-only Rails applications without the need to change the host application.
I only tested it with a bare api_only application and my own non-api_only application and it seems to work, but we probably need more tests.
propshaft
as a dependency and required it (maybe we should conditionally require it based on if the host app already has any asset pipeline setup? can propshaft can cause issues with applications using Rails <7? Should we go for sprockets instead?)ActionController::Base
modules inApplicationController
, unless they're already included (maybe we should be more selective?)ApplicationController
, unless they're already includedActionDispatch::Flash
middleware if not already setup